Skip to content

use cm6 keymap instead of event listener#93

Closed
nightwing wants to merge 1 commit intomasterfrom
cm6-keymap
Closed

use cm6 keymap instead of event listener#93
nightwing wants to merge 1 commit intomasterfrom
cm6-keymap

Conversation

@nightwing
Copy link
Copy Markdown
Collaborator

attempt to fix tests for the approach proposed in #54

Copy link
Copy Markdown
Contributor

@sergeichestakov sergeichestakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet 🧪

@nightwing nightwing changed the title [WIP] use cm6 keymap instead of event listener use cm6 keymap instead of event listener Mar 19, 2023
@nightwing
Copy link
Copy Markdown
Collaborator Author

I am actually not sure if we should use this or not.
The only change seems to be the key in autocompletion closing the popup instead of exiting the insert mode immediately, and though this behavior seems more intuitive to me, vim itself exits the insert mode immediately, like we do now.

@sergeichestakov
Copy link
Copy Markdown
Contributor

ahh I see so it takes two clicks of esp to get back to insert mode? agree we should keep current behavior and close the popup + exit insert mode in one click

@nightwing
Copy link
Copy Markdown
Collaborator Author

In that case i guess we should close both of these pull requests, unless we find some other reason to make the switch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants