Explicitly pass in arch to make when building, mark GH workflow files as config#135
Merged
sergeichestakov merged 2 commits intomainfrom Oct 13, 2023
Merged
Conversation
sergeichestakov
changed the title
sergeichestakov
requested review from
a team,
Monkatraz,
gburtini and
szymonkaliski
and removed request for
a team and
gburtini
szymonkaliski
approved these changes
Oct 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We pass in the arch in the publish workflow so we should do it here for consistency.
In addition, we should rerun the build step anytime any of the workflow files change since those can affect the build.
What changed
Explicitly pass in arch to make in the build workflow. Rerun build step when anything under
.github/workflowschangesTest plan
Build steps should run and pass