Skip to content

Fix generating cert on M1 machines and sign apps in build workflow #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sergeichestakov merged 12 commits into from
Oct 16, 2023
Merged

Fix generating cert on M1 machines and sign apps in build workflow #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8910fc5
1.0.4
sergeichestakov Oct 16, 2023
c6142ba
Sign apps with build workflow
sergeichestakov Oct 16, 2023
8771af6
fix dir name
sergeichestakov Oct 16, 2023
e6eff9b
Pass in identity
sergeichestakov Oct 16, 2023
d262bb8
More specific
sergeichestakov Oct 16, 2023
88090d6
Pass in debug env
sergeichestakov Oct 16, 2023
0603ed4
Empty obj
sergeichestakov Oct 16, 2023
1400c9c
Test find-identity, skip everything else for now
sergeichestakov Oct 16, 2023
5859c06
Reset package.json
sergeichestakov Oct 16, 2023
057e6e6
Actually generate the certs
sergeichestakov Oct 16, 2023
275aa68
Remove excludes
sergeichestakov Oct 16, 2023
9badba4
Remove debug
sergeichestakov Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
- package.json
- tsconfig.json
- forge.config.js
- .github/workflow/**
- .github/workflows/**

make:
name: Make (${{ matrix.os }} - ${{ matrix.arch }})
Expand Down Expand Up @@ -82,5 +82,25 @@ jobs:
cache: pnpm
- name: Install
run: pnpm install
- name: Generate Windows code signing certificate
if: matrix.os == 'windows-latest'
id: write_file
uses: timheuer/base64-to-file@v1.2
with:
fileName: 'windows-certificate.pfx'
encodedString: ${{ secrets.WINDOWS_CODESIGN_CERTIFICATE }}
- name: Generate MacOS code signing certificate
if: matrix.os == 'macOS-latest' || matrix.os == 'macOS-13-xlarge'
run: ./scripts/add-macos-cert.sh
env:
MACOS_CERT_P12: ${{ secrets.MACOS_CERT_P12 }}
MACOS_CERT_PASSWORD: ${{ secrets.MACOS_CERT_PASSWORD }}
- name: Make
run: pnpm run make --arch=${{ matrix.arch }}
env:
APPLE_ID: ${{ secrets.APPLE_ID }}
APPLE_PASSWORD: ${{ secrets.APPLE_PASSWORD }}
APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
WINDOWS_CERTIFICATE_FILE: ${{ steps.write_file.outputs.filePath }}
WINDOWS_CERTIFICATE_PASSWORD: ${{ secrets.WINDOWS_CODESIGN_PASSWORD }}
GITHUB_TOKEN: ${{ secrets.GH_TOKEN }}
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
fileName: 'windows-certificate.pfx'
encodedString: ${{ secrets.WINDOWS_CODESIGN_CERTIFICATE }}
- name: Generate MacOS code signing certificate
if: matrix.os == 'macOS-latest'
if: matrix.os == 'macOS-latest' || matrix.os == 'macOS-13-xlarge'
run: ./scripts/add-macos-cert.sh
env:
MACOS_CERT_P12: ${{ secrets.MACOS_CERT_P12 }}
Expand Down