Skip to content

Cleanup logs in dev#141

Merged
sergeichestakov merged 1 commit intomainfrom
@sergeichestakov/dev-version
Nov 1, 2023
Merged

Cleanup logs in dev#141
sergeichestakov merged 1 commit intomainfrom
@sergeichestakov/dev-version

Conversation

@sergeichestakov
Copy link
Copy Markdown
Contributor

Why

I wanna add (development) to the outputted version in the logs in dev to make it more obvious that the app is not packaged and therefore has certain implications (like not supporting auto-updating). Also, the arch is arguably part of the "platform" so think we can condense this log into one.

What changed

Just cleaning up some logs

Test plan

  • pnpm start
  • Should see updated logs

@sergeichestakov sergeichestakov self-assigned this Nov 1, 2023
@sergeichestakov sergeichestakov requested review from a team and siliconjungle and removed request for a team November 1, 2023 20:06
Copy link
Copy Markdown

@siliconjungle siliconjungle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good change!

@sergeichestakov sergeichestakov merged commit b3a2f7f into main Nov 1, 2023
@sergeichestakov sergeichestakov deleted the @sergeichestakov/dev-version branch November 1, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants