Update Node/pnpm engines to match repl-it-web#142
Merged
sergeichestakov merged 2 commits intomainfrom Nov 22, 2023
Merged
Conversation
sergeichestakov
requested review from
a team and
Monkatraz
and removed request for
a team
siliconjungle
approved these changes
Nov 22, 2023
siliconjungle
left a comment
siliconjungle
left a comment
There was a problem hiding this comment.
Seems good - there may be incompatibility issues that arise, but worst case people can just switch their pnpm version locally.
Monkatraz
approved these changes
Nov 22, 2023
Monkatraz
left a comment
Monkatraz
left a comment
There was a problem hiding this comment.
probably fine, makes it easier to setup everything
Contributor
Author
|
wdym incompatibility? this is exactly what we do in the web app? this is more flexible as it allows for >=8.5.1 instead of just that one specific version |
Contributor
Author
|
build failing, seems unrelated. will follow up with a fix |
sergeichestakov
deleted the
@sergeichestakov/match-replit-web-engines
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Matches repl-it-web and more flexibility in which pnpm version you can use (I'm on the latest now)
What changed
Update Node/pnpm engines to match repl-it-web
Test plan
pnpm start