Merged
Conversation
sergeichestakov
requested review from
a team and
jackyzha0
and removed request for
a team
jackyzha0
approved these changes
Dec 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We're ~5 weeks behind which apparently is 2 major versions. Anyways, the immediate impetus for this upgrade is to see if this fixes the crashes we've been seeing that users are reporting frequently. Judging by the responses in this issue it seems upgrading from v26 to v28 has helped at least a few people: electron/electron#37531 (comment)
As with any version bump, we should see some misc bug fixes/improvements.
What changed
Upgrade Electron to 28.1.0
Test plan
Should see fewer crashes in Sentry. Otherwise, the desktop app should largely work and function the same.