Log when openExternal is called in window event handlers#153
Merged
sergeichestakov merged 1 commit intomainfrom Mar 21, 2024
Merged
Log when openExternal is called in window event handlers#153sergeichestakov merged 1 commit intomainfrom
sergeichestakov merged 1 commit intomainfrom
Conversation
WS-2021 Replit desktop application bug: Somehow I got unauthenticated in the desktop app, while the app w...
devon.stewart said:
|
joe-thom
approved these changes
Mar 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We've been seeing a bug in the app where a certain repl or tab will be opened in your browser while the app is running in the background. I'm not sure why this happens tbh and can't find any logs from those that have reported this issue in Datadog (which is where we log when we open external URLs on the web side) so we should add some logging on the native side too to help us investigate. See attached Linear issue and Slack thread for more detail.
references WS-2021
What changed
Log when openExternal is called in window event handlers. Also replacing a use of the deprecated
navigationUrlparam while I'm at itTest plan