Only open windows externally if window is focused#156
Merged
sergeichestakov merged 1 commit intomainfrom May 2, 2024
Merged
Conversation
sergeichestakov
requested review from
a team,
ink404,
lunaroyster and
szymonkaliski
and removed request for
a team
szymonkaliski
approved these changes
May 2, 2024
Contributor
szymonkaliski
left a comment
szymonkaliski
left a comment
There was a problem hiding this comment.
this is good, but feels like a band-aid, is there any way in which we could know what's actually causing the windows to open randomly?
Contributor
Author
|
yes definitely a band-aid 😕 Not sure yet but will keep digging |
Contributor
Author
|
corresponding web PR: https://github.com/replit/repl-it-web/pull/43941 |
Contributor
Author
|
FYI @szymonkaliski figured it out here: https://github.com/replit/repl-it-web/pull/44658 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We've gotten some reports of the desktop app randomly opening pages when unfocused and in the background. I have a feeling this is due to some of our "openExternal" logic around redirecting non-Replit pages (or those not supported in the desktop app) to the user's browser instead. I'm not sure why this would be occurring in the background since this should usually only happen by the user clicking links or something triggering
window.openbut evidently it is. See Slack thread.What changed
Only open external links in the user's browser if the window is actually focused. This will stop tabs from opening when the app is in the background.
Test plan
window.openin the console when the app is focused -> should still open external links in the browser