Remove open from clipboard menu item#157
Merged
sergeichestakov merged 1 commit intomainfrom May 9, 2024
Merged
Conversation
WS-3389 Bug: "Open URL from clipboard" feature fails in desktop app
said:
|
sergeichestakov
requested review from
a team,
pstoica and
szymonkaliski
and removed request for
a team
pstoica
approved these changes
May 9, 2024
Contributor
agreed, one good way to this might be to check the clipboard for replit.com URLs when the application re-gains focus and show a toast notification if a valid URL is detected, offering to open that repl |
Contributor
Author
|
yep not a bad idea! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
It's currently broken for team repls since only the old Repl URL format is supported (and not the most correct one at that).
We can trivially add support for it but I'm thinking it's better to just remove this feature since it's not clear anyone is deriving value from this and it's pretty un-intuitive to use. We should instead follow up with an easier way to open a Repl with a given URL baked into the UI rather than a hidden / confusing menu item.
Closes WS-3389
What changed
Remove open from clipboard menu item
Test plan