Upgrade dependencies: Electron 35, Sentry 5, TypeScript 5.8, esbuild 0.25#188
Merged
Upgrade dependencies: Electron 35, Sentry 5, TypeScript 5.8, esbuild 0.25#188
Conversation
Member
Contributor
|
thank you @moudy 🙏 you are a hero & a saint 👼 I fully approve of and endorse this wonderful pull request. I no longer have write access to this repo so cannot personally contribute but I will be cheering from the sidelines. |
Member
|
fixed:
|
Armster15
approved these changes
Apr 14, 2026
Member
Armster15
left a comment
There was a problem hiding this comment.
noticed we're no longer building for intel macs. fine for now considering apple silicon was introduced in 2020 (meaning 6 years have passed). can always bring back if necessary
lgtm otherwise
Contributor
Author
|
Oh hi @sergeichestakov! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Why
The desktop app dependencies haven't been updated in a long time. Electron 30 shipped Chromium 124 (over a year old) and reached end-of-life in October 2024, meaning users are running on an unpatched browser engine. The Sentry SDK, TypeScript, esbuild, and Electron Forge versions were also significantly outdated with known security vulnerabilities in transitive dependencies. The CI workflows also used deprecated runners and outdated action versions.
What changed
Electron 30 → 35 (Chromium 124 → 134)
@sentry/electron 4 → 5
@sentry/electronto@sentry/electron/main(v5 splits main/renderer exports)crashReporter.start()— Sentry v5 handles native crash reporting (minidumps) automatically via built-in integrationsElectron Forge 7.4 → 7.11
TypeScript 4.9 → 5.8
es2015toes2020(Electron 35 supports far beyond ES2015)skipLibCheck: truefor faster type checkingesbuild 0.18 → 0.25
es2015toes2020to match tsconfigCI workflow updates:
20.10.x→22.x8.5.1→9macOS-12→macos-13(macOS-12 deprecated on GitHub Actions, removed June 2025)actions/checkoutv3 → v4actions/setup-nodev3 → v4pnpm/action-setupv2 → v4Other dependency updates:
@typescript-eslint/*4-6 → 7 (stays compatible with ESLint 8 and.eslintrcconfig)electron-log5.1.4 → 5.4.xelectron-winstaller5.3 → 5.4prettier3.0 → 3.8rimraf5 → 6@types/node20 → 22eslint-plugin-prettier,eslint-config-prettierminor bumps^20.10.0to>=20.10.0Not upgraded (intentionally):
electron-storestays at v8 — v9+ is ESM-only, incompatible with our CJS buildeslintstays at v8 — v9+ requires flat config migration (large churn, low user-facing value)@sentry/electronstops at v5 not v7 — v7 requires Sentry JS SDK v9 with significant API changes; v5 preserves the sameinit/setUser/captureExceptionAPITest plan
pnpm run ci(build + typecheck + lint) passes cleanlypnpm auditshows remaining vulnerabilities are all in dev-only transitive dependencies (Electron Forge build toolchain) — none ship in the production appmakeon the full platform matrix sincepackage.json,tsconfig.json, and workflow files changedRevertibility
Safe to revert. No data migrations, no protocol changes. Just dependency version bumps, two import path changes in source, and CI config updates.
~ written by Zerg 👾 (commanding-fang-2680)