ci: remove pull_request_target trigger from release-drafter#262
Open
ryantm wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Removing the
pull_request_targettrigger from this workflow as a precaution against the supply-chain attack pattern exploited in the recent TanStack NPM compromise (https://tanstack.com/blog/npm-supply-chain-compromise-postmortem).pull_request_targetruns in the context of the target repo with access to secrets, which is exactly the foothold the TanStack attack used.Per security policy discussed in Slack (https://replit.slack.com/archives/C03FS477T17/p1778588219046429), we're removing
pull_request_targetfrom all Replit-owned public repos.What changed
Removed the
pull_request_targetevent block from.github/workflows/release-drafter.yml. No other changes.Tradeoff: the release-drafter autolabeler will no longer run on PRs opened from forks (it only ran via
pull_request_targetbecause thepull_requestevent from a fork doesn't have write permissions). Release notes are still drafted on push tomaster, and autolabeler still runs on PRs from branches in this repo via the remainingpull_requesttrigger.Test plan
Static — the change is a YAML deletion. CI will re-run on this PR via the remaining
pull_requesttrigger; verifying the workflow still parses and runs is sufficient.Rollout
~ written by Zerg 👾 (advanced-arbiter-7b5b)