-
Notifications
You must be signed in to change notification settings - Fork 93
Description
Describe the bug
client-Python library can crash the execution process, if it wasn't able to decode responded JSON payload. The lib cannot intercept "JSONDecodeError" exception, since it's imported from the "json" package. But "requests" package can also raise "JSONDecodeError" exception from the "simplejson" package, if it's installed in the environment. Thus, both exception must be handled here: https://github.com/reportportal/client-Python/blob/develop/reportportal_client/core/rp_responses.py#L91
Steps to Reproduce
- Install "simplejson" with the client lib itself
- Return non-valid JSON payload from the ReportPortal server
Expected behavior
Both exception ("JSONDecodeError" from "json" and "simplejson" pcakges) must be handled here: https://github.com/reportportal/client-Python/blob/develop/reportportal_client/core/rp_responses.py#L91
Actual behavior
Only "JSONDecodeError" from "json" package is handled here: https://github.com/reportportal/client-Python/blob/develop/reportportal_client/core/rp_responses.py#L91
Package versions
reportportal-client==5.5.8
Additional context
Add any other context about the problem here.