Skip to content

[#828] Revert PR #800#832

Merged
eugenepeh merged 2 commits intoreposense:masterfrom
jamessspanggg:revert-pr-800
Jul 24, 2019
Merged

[#828] Revert PR #800#832
eugenepeh merged 2 commits intoreposense:masterfrom
jamessspanggg:revert-pr-800

Conversation

@jamessspanggg
Copy link
Copy Markdown
Contributor

@jamessspanggg jamessspanggg commented Jul 24, 2019

Fixes #828

PR #800 was intended to ensure the getFiltered() method to be executed 
only once when the page is reloaded. The solution used was to set 
boolean canGetFiltered to true in beforeUpdate() lifecycle hook, 
preventing the execution of getFiltered() before the lifecycle hook.
However, the beforeUpdate() lifecycle hook will only be executed when 
there are changes to the DOM. 

Instances where the page is reloaded and there are no changes to the DOM
will not set boolean canGetFiltered to true, preventing getFiltered() to 
be executed until the DOM has changed.

Let's revert PR #800 to allow getFiltered() to be executed even when 
there are no changes to the DOM.

@jamessspanggg jamessspanggg marked this pull request as ready for review July 24, 2019 03:00
@jamessspanggg jamessspanggg requested review from a team and eugenepeh July 24, 2019 03:01
@jamessspanggg jamessspanggg requested a review from a team July 24, 2019 07:08
@eugenepeh eugenepeh merged commit 1378e60 into reposense:master Jul 24, 2019
bluein-green added a commit to bluein-green/RepoSense that referenced this pull request Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mistake made in merged PR #800

3 participants