Skip to content

Conversation

@netomi
Copy link
Contributor

@netomi netomi commented Oct 3, 2023

This PR fixes a few further unit test problems that I encountered:

  • gather method for redis backend works fine, so enabled the test
  • ensure files generated during test are created in tmp directory
  • ensure that all method calls during test execution happen within a context manager to properly close the cache (otherwise a sqlite connection hangs around in some cases)

With all these fixes, running all tests in my IDE successfully completes without any hanging thread.

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (8ed3214) 97.21% compared to head (8f787d0) 97.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #186   +/-   ##
=======================================
  Coverage   97.21%   97.21%           
=======================================
  Files          10       10           
  Lines         934      934           
  Branches      171      171           
=======================================
  Hits          908      908           
  Misses         15       15           
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JWCook JWCook added bug Something isn't working tests labels Oct 3, 2023
@JWCook JWCook added this to the v0.10 milestone Oct 3, 2023
@JWCook JWCook merged commit c7ec56f into requests-cache:main Oct 3, 2023
@netomi netomi deleted the further-unit-test-fixes branch October 30, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants