Merged
Conversation
andrea-reale
changed the title
jprochazk
approved these changes
Sep 25, 2025
andrea-reale
force-pushed
the
andrea/azure-https
branch
from
460ea01 to
0fa261e
Compare
`object_store` supports several ways of encoding the address of Azure Blob Storage URLs, as specified [here](https://github.com/apache/arrow-rs-object-store/blob/b82979d44a916cf1615e719c8e80800766fd6efe/src/azure/builder.rs#L531). Before this change, the lance wrapper only supported the `az` scheme. However, the other schemes are significant too because they allow to encode extra information (e.g., the Azure Storage account name) or access different store type (e.g., Files Blob Store). This change, maps `https` object URIs to Azure, so that the underlying `object_store` support can be effectively used. Signed-off-by: Andrea Reale <andrea@rerun.io>
andrea-reale
force-pushed
the
andrea/azure-https
branch
from
0fa261e to
2ec1b9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
object_storesupports several ways of encoding the address of AzureBlob Storage URLs, as specified here.
Before this change, the lance wrapper only supported the
azscheme.However, the other schemes are significant too because they allow to
encode extra information (e.g., the Azure Storage account name) or
access different store type (e.g., Files Blob Store).
This change, maps
httpsobject URIs to Azure, so that the underlyingobject_storesupport can be effectively used.