Fix clipboard usage on Windows#172
Merged
Merged
Conversation
Member
Author
|
Sibling PR: emilk/egui#2120 |
Contributor
|
How was this tested? Do you have access to a Windows machine? |
jondo2010
approved these changes
Oct 10, 2022
Member
Author
Tested? Sir, you over-estimate me! No, I don't have a Windows machine 😬 |
emilk
added a commit
that referenced
this pull request
Nov 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As was just pointed out to me,
arboardhad a breaking change in 3.0 that meant you must absolutely not hold on to thearboard::Clipboardfor longer than you are using it.Thankfully, this just makes the code shorter and simpler.
See 1Password/arboard#84 for more details.