Support renaming fields in inline records #6391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
approved these changes
Sep 7, 2023
Collaborator
cristianoc
left a comment
cristianoc
left a comment
There was a problem hiding this comment.
Thanks a lot for doing this!
Checked, and gentype was already supporting this, so no adaptation required there.
Contributor
Author
|
Btw the original PR also add support for exception UserException({@as("renamed") name: string})But this code doesn't parse in rescript (syntax error). Is it something we should support ? |
Member
4 tasks
Member
|
unfortunately it seems that this PR only works for creating such variants but not for accessing those fields. cf #6438 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from melange-re/melange#732