Conversation
gabrielecalvo
previously approved these changes
Sep 5, 2024
Contributor
Author
|
I think the "Some checks haven’t completed yet" status is due to this issue https://github.com/orgs/community/discussions/26698 |
aclerc
added a commit
that referenced
this pull request
Sep 8, 2024
* Update smarteole_example.ipynb fix issue, CACHE_SUBDIR is missing if data has never been downloaded * Update smarteole_example.ipynb fix ruff issue * Update smarteole_example.ipynb try to fix ruff issue * fix issues after updating ruff * Fix plotconfig mkdir (#16) * remove make_plots_dir * Update main_analysis.py fix missing dir issue * bump version * Update smarteole_example.ipynb * Update smarteole_example.ipynb filter SmallSampleWarning * Update smarteole_example.ipynb fix ruff issue * Create wind-up uplift validation methodology.pdf * Cleanup requests dependency and move to examples group (#19) * Cleanup requests dependency and move to examples group * Jupyter group moved to examples and all group added * Update pyproject.toml define all using other groups --------- Co-authored-by: Alex Clerc <alex.clerc@res-group.com> * support Python 3.9 (#17) * try Python 3.9 in workflow * Update lint-and-test.yaml * try from __future__ import annotations * Update conftest.py * add eval-type-backport * more from __future__ import annotations * remove TypeAlias * replace zip with strict_zip * ignore 3.9 mypy issues * fix bug in backporting.py * Update lint-and-test.yaml * Update lint-and-test.yaml * Update pyproject.toml move types-requests to dev * Update smarteole_example.ipynb * Update smarteole_example.ipynb * Update smarteole_example.ipynb * Define supported python (#23) * add badge to README * Update pyproject.toml * Update lint-and-test.yaml * update classifiers * Update lint-and-test.yaml * Update README.md * Update smarteole_example.ipynb * Update lint-and-test.yaml * Update README.md * Update smarteole_example.ipynb * fix methodology link --------- Co-authored-by: Gorkem Kacar <139143704+izofat@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is necessary for NatLabRockies/flasc#210 because FLASC supports 3.9
Main changes:
from __future__ import annotationswhere necessaryeval-type-backportneeded for pydanticstrict_zipbecause in Python 3.9zipcannot use thestrictkwarg