Skip to content

Conversation

@rburghol
Copy link
Contributor

@rburghol rburghol commented Jan 26, 2026

This is NOT to be merged. This should be closed after #208 is merged -- the issues raised in this PR are now visible in active issue #209

@rburghol

This comment was marked as outdated.

@rburghol

This comment was marked as duplicate.

@rburghol
Copy link
Contributor Author

Errors from hsp2 code in main.py and utilities.py related to pandas version deprecation have been resolved as of 1/26/2026

The failing tests have some things in common with respect to pandas:

  • The tests with python <= 3.10 all pass
  • The tests with pandas < 2.0 all pass
  • The tests that are failing now have pandas > 3.0, from test-cmd 3.12: Downloading pandas-3.0.0-cp312-cp312-manylinux_2_24_x86_64.manylinux_2_28_x86_64.whl.metadata (79 kB)
  • The python > 3.10 tests that passed last week had installed pandas 2.3.3, like my PR develop-if-parser test for 3.12 reports: Using cached pandas-2.3.3-cp312-cp312-manylinux_2_24_x86_64.manylinux_2_28_x86_64.whl.metadata (91 kB)
  • The errors were reporting TypeError: unsupported operand type(s) for /: 'pandas._libs.tslibs.offsets.Minute' and 'pandas._libs.tslibs.offsets.Day',

@rburghol
Copy link
Contributor Author

rburghol commented Jan 27, 2026

As of 1/27: Fixed error by explicitly closing the hdf5 at the end of the run() command in commands.py

  • (test10 and test10specl) x python > 3.10 fails ValueError: The file '/opt/model/HSPsquared/tests/test10/HSPFresults/test10.h5' is already opened, but not in read-only mode (as requested).
    • Wondering if this is still open at the end of the run command, that is also triggered inside the same code object method (test_regression.py both runs and analyzes output).
    • In the past, my own shell tests indicate that the run command may not close the hdf5.
    • Suggest that maybe running separately in the test config, similar to the manner in which it is run in the standard testcmd steps, which then should close the file as this automatically occurs.
    • Ideally, the cmd run should tidy up by closing the hdf5, but I think that the workflow for the test would still be better served by not running the model and loading the data in the same step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant