First commit of gRPC Bridge example #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamezp
reviewed
Apr 21, 2023
Member
jamezp
left a comment
jamezp
left a comment
There was a problem hiding this comment.
I wasn't sure if this was just to push something up or you wanted a review on it, so I gave it a quick review :)
grpc-bridge-example/src/main/java/dev/resteasy/greet/GeneralGreeting.java
Outdated
Show resolved
Hide resolved
grpc-bridge-example/src/main/java/dev/resteasy/greet/GeneralGreeting.java
Outdated
Show resolved
Hide resolved
grpc-bridge-example/src/main/java/dev/resteasy/greet/Greeting.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks, @jamezp. There was something I figured would change, so I made it a WIP. Can't remember what, though. :-P |
Contributor
Author
|
Oh, I know. I figure the new grpc-bridge project would have its own feature layer, so my description of creating a WildFly will change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.