Conversation
Closed
|
Hey 👋 Thank you in advance and thanks for all the great work getting version 9 released! |
Contributor
Author
|
We're aiming for the week of Nov 28 |
3 tasks
mmarchini
force-pushed
the
node-18-alt
branch
from
08e25bb to
a4937aa
Compare
sternam
approved these changes
Nov 23, 2022
3 tasks
* Remove `closed()` monkey-patch, rely on connectionState instead (restifyGH-1888) * fix IPv6 url by supporting new server.address().family format * add node 18 to GH Actions Co-authored-by: mary marchini <oss@mmarchini.me>
mmarchini
force-pushed
the
node-18-alt
branch
from
a4937aa to
0a94440
Compare
4 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closed()monkey-patch, rely on connectionState instead (restify cannot be imported with latest node v18.0.0 nightly:Request.prototype.closedpatch clashes with new Readable.closed getter #1888)Co-authored-by: mary marchini oss@mmarchini.me
Pre-Submission Checklist
make prepushIssues
Closes:
Changes