Merged
Conversation
martinzima
force-pushed
the
fix/angular-20
branch
from
a2cdc32 to
43215e8
Compare
There was a problem hiding this comment.
Pull Request Overview
Adds support for Angular 20 by mirroring the existing v19 setup in a new ng20 sub-package and updating the root configuration.
- Updated root
package.jsonscripts and peer dependencies to include Angular 20. - Introduced an
ng20package with a tailoredtsconfig.json, build scripts, and package metadata. - Added patch modules for each preset (reroute, minimap, context-menu, classic) to register standalone components under Angular 20.
Reviewed Changes
Copilot reviewed 14 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Include build:20/postinstall entries and extend peerDependencies to <21 |
| ng20/tsconfig.json | Define Angular 20 compiler options |
| ng20/src | Symlink reference to the common src directory |
| ng20/patch/presets/reroute/module.ts | Add Rete reroute preset NgModule for Angular 20 |
| ng20/patch/presets/reroute/components/pins/.pins.component.ts | Patch pins component imports for reroute preset |
| ng20/patch/presets/minimap/module.ts | Add Rete minimap preset NgModule for Angular 20 |
| ng20/patch/presets/minimap/components/minimap/.minimap.component.ts | Patch minimap component imports |
| ng20/patch/presets/context-menu/module.ts | Add Rete context-menu preset NgModule for Angular 20 |
| ng20/patch/presets/context-menu/components/menu/.menu.component.ts | Patch menu component imports |
| ng20/patch/presets/context-menu/components/item/.item.component.ts | Patch item component imports |
| ng20/patch/presets/classic/components/node/.node.component.ts | Patch classic node component imports |
| ng20/patch/module.ts | Define root ReteModule NgModule for Angular 20 |
| ng20/package.json | Set up ng20 package metadata and devDependencies |
| ng20/ng-nested.js | Configure ng-packagr for nested Angular 20 package |
Comments suppressed due to low confidence (1)
ng20/package.json:2
- No tests were added for the new Angular 20 package—consider introducing unit and e2e tests to verify the build and patched modules work as expected.
"name": "rete-angular-plugin-ng20",
| "$schema": "./node_modules/ng-packagr/ng-package.schema.json", | ||
| "dest": "../dist/20", | ||
| "lib": { | ||
| "entryFile": "./.src/index.ts" |
There was a problem hiding this comment.
The entryFile path references ./.src/index.ts, but the symlink is created as ng20/src. Rename the directory to .src or update this path to ./src/index.ts so packagr can locate the entry file.
Suggested change
| "entryFile": "./.src/index.ts" | |
| "entryFile": "./src/index.ts" |
Comment on lines
+4
to
+6
| import { ContextMenuComponent } from './components/menu/menu.component' | ||
| import { ContextMenuSearchComponent } from './components/search/search.component' | ||
| import { ContextMenuItemComponent } from './components/item/item.component' |
There was a problem hiding this comment.
[nitpick] Add semicolons at the end of these import statements (lines 4–6) to match the prevailing project style and avoid lint errors.
Suggested change
| import { ContextMenuComponent } from './components/menu/menu.component' | |
| import { ContextMenuSearchComponent } from './components/search/search.component' | |
| import { ContextMenuItemComponent } from './components/item/item.component' | |
| import { ContextMenuComponent } from './components/menu/menu.component'; | |
| import { ContextMenuSearchComponent } from './components/search/search.component'; | |
| import { ContextMenuItemComponent } from './components/item/item.component'; |
Member
|
@martinzima thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have added Anguar 20 version. Pretty much everything isthe same as for version 19.
Related Issues
Checklist
Additional Notes
Let me know if anything else needs to be updated!