Open
Conversation
reub-the-cube
force-pushed
the
code-review-python
branch
from
1369f01 to
b7343c3
Compare
| cursor = conn.cursor() | ||
|
|
||
| # Find users matching the search | ||
| query = f"SELECT username, email FROM users WHERE username LIKE '%{search_term}%'" |
There was a problem hiding this comment.
SQL injection vulnerability - Attacker can inject string query and return sensitive data
| @app.route('/admin') | ||
| def admin_panel(): | ||
| user_role = request.args.get('role') | ||
| if user_role == 'admin': |
There was a problem hiding this comment.
Broken access control - Attacker can assign themselves admin role using the URL request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Think about what we've discussed: injection, access control, authentication.