Require PHP 8.1 and use features #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trowski
commented
Feb 22, 2022
| } | ||
| throw new \Error($message); | ||
| \set_error_handler(static function (int $errno, string $errstr): bool { | ||
| throw new \Error(\sprintf("Failed to register signal handler; Errno: %d; %s", $errno, $errstr)); |
Member
Author
There was a problem hiding this comment.
Should this be a RuntimeException instead?
Member
There was a problem hiding this comment.
Probably our unsupported feature exception could be used?
kelunik
approved these changes
Feb 22, 2022
Neither of these is technically wrong, but Psalm complains.
Contributor
|
👍 , everything I'm doing with fibers is 8.1+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple somewhat tangential changes:
@operator when callingpcntl_signalinStreamSelectDriver.AbstractDriver, since the file won't parse in PHP versions below 8.1, it seemed pointless to retain it.