Replace getInfo with reflection API #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelunik
force-pushed
the
reflection-api
branch
from
d31f8a1 to
f2b303c
Compare
azjezz
approved these changes
Oct 16, 2022
Member
Author
|
See revoltphp/revoltphp.github.io#4 for the documentation PR. |
trowski
approved these changes
Oct 18, 2022
Member
trowski
left a comment
trowski
left a comment
There was a problem hiding this comment.
I maybe would have added abstract public function getType(): CallbackType to DriverCallback and avoided the match and lookup when looping through callbacks, but it's all internal so doesn't really matter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows applications to get the metrics they want to collect.