Fix Fiber leaks if Suspension never resumed

src/EventLoop/Internal/AbstractDriver.php

@@ -285,12 +285,21 @@ public function getSuspension(): Suspension
         \assert($fiber !== $this->fiber);
 
         // Use current object in case of {main}
-        return $this->suspensions[$fiber ?? $this] ??= new DriverSuspension(
+        if (isset($this->suspensions[$fiber ?? $this])) {
+            if ($suspension = $this->suspensions[$fiber ?? $this]->get()) {
+                return $suspension;
+            }
+        }
+
+        $suspension = new DriverSuspension(
             $this->runCallback,
             $this->queueCallback,
             $this->interruptCallback,
             $this->suspensions
         );
+        $this->suspensions[$fiber ?? $this] = \WeakReference::create($suspension);
+
+        return $suspension;
     }
 
     public function setErrorHandler(?\Closure $errorHandler): void

src/EventLoop/Internal/DriverSuspension.php

@@ -104,17 +104,17 @@ public function suspend(): mixed
             $info = '';
             $suspensions = $this->suspensions->get();
             if ($suspensions) {
-                \gc_collect_cycles();
-
-                /** @var self $suspension */
-                foreach ($suspensions as $suspension) {
-                    $fiber = $suspension->fiberRef?->get();
-                    if ($fiber === null) {
-                        continue;
+                foreach ($suspensions as $suspensionRef) {
+                    /** @var self $suspension */
+                    if ($suspension = $suspensionRef->get()) {
+                        $fiber = $suspension->fiberRef?->get();
+                        if ($fiber === null) {
+                            continue;
+                        }
+
+                        $reflectionFiber = new \ReflectionFiber($fiber);
+                        $info .= "\n\n" . $this->formatStacktrace($reflectionFiber->getTrace(\DEBUG_BACKTRACE_IGNORE_ARGS));
                     }
-
-                    $reflectionFiber = new \ReflectionFiber($fiber);
-                    $info .= "\n\n" . $this->formatStacktrace($reflectionFiber->getTrace(\DEBUG_BACKTRACE_IGNORE_ARGS));
                 }
             }
 

test/EventLoopTest.php

@@ -269,8 +269,7 @@ public function testSuspensionWithinCallbackGarbageCollectionSuspended(): void
 
         \gc_collect_cycles();
 
-        // This documents an expected failure, should actually be true, but suspensions have to be resumed currently.
-        self::assertNull($finally);
+        self::assertTrue($finally);
     }
 
     public function testSuspensionWithinQueue(): void