This repository was archived by the owner on Nov 26, 2024. It is now read-only.
Merged
Conversation
BadChoice
suggested changes
Jun 27, 2023
src/resources/views/edit.blade.php
Outdated
| <div class="configForm"> | ||
| <h2> {{ $object->{$nameField} ?? __('thrust::messages.new') }}</h2> | ||
| <h2> | ||
| @forEach(explode('/', $objectName ?: __('thrust::messages.new')) as $pathComponent) |
There was a problem hiding this comment.
posem-ho dins d'un @include('breadcums')
src/Resource.php
Outdated
|
|
||
| public function editTitle(mixed $object): ?string | ||
| { | ||
| return $object->{$this->nameField}; |
There was a problem hiding this comment.
editTitle Sembla una accio, li podriem canviar per
titleAtEdit() : string
src/Html/Index.php
Outdated
| { | ||
| return $this->resource->fieldsFlattened()->filter(function($field){ | ||
| return $field->showInIndex;// && $this->resource->can($field->policyAction); | ||
| return $field->showInIndex || request('search') && $field->showWhileSearching; |
There was a problem hiding this comment.
posem el or i && junts per veure més clar que van junts (i en una linia a sota)
Author
There was a problem hiding this comment.
No entec la proposta. Vols dir així?
return $field->showInIndex
|| request('search') && $field->showWhileSearching;
src/Fields/Field.php
Outdated
|
|
||
| public $showInIndex = true; | ||
| public $showInEdit = true; | ||
| public $showWhileSearching = false; |
There was a problem hiding this comment.
jo mantindria la coherencia, showInSearch
BadChoice
approved these changes
Jun 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added context to child resoruce's edit
Added displayWhileSearching property to field
https://linear.app/revo/issue/REV-11882/versio-thurst