Don't replace variables not specified in variables#5
Open
hughsk wants to merge 1 commit intoreworkcss:masterfrom
Open
Don't replace variables not specified in variables#5hughsk wants to merge 1 commit intoreworkcss:masterfrom
variables#5hughsk wants to merge 1 commit intoreworkcss:masterfrom
Conversation
Contributor
|
can you add tests? btw i recommend just using https://github.com/reworkcss/rework-vars since it actually somewhat complies with a spec |
Contributor
|
you still interested in this? i can just add you to the org if you want to maintain this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unsure if it's the current intended behavior, but if a variable is falsey or undefined, it'll just remove the
$symbol and leave the variable name there.For example:
Using:
Currently results in:
Meaning that any future applications of
rework-variablesanywhere else won't be able to pick up the missing variable and replace it. This patch changes the ouptut of the above example to be:Thanks! :)