Revert "Set -DENABLE_MODERN flag to ON by default and remove it (#66)" #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 077fdbc.
…-messaging#66)" This reverts commit 0f8f904.
jiridanek
force-pushed
the
jd_2022_10_19_include_proton_fix_win_job
branch
from
84d02bf to
ae01f79
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| These variables apply to all code base and may affect what code is built with | ||
| along with the project. For example, they may enable refactored code. | ||
|
|
||
| * ENABLE_MODERN: Enable new and/or refactored code. It is a requirement for -DENABLE_QPID_PROTON. |
Check notice
Code scanning / Markdownlint (reported by Codacy)
Expected: 0 or 2; Actual: 1
| These variables apply to all code base and may affect what code is built with | ||
| along with the project. For example, they may enable refactored code. | ||
|
|
||
| * ENABLE_MODERN: Enable new and/or refactored code. It is a requirement for -DENABLE_QPID_PROTON. |
Check notice
Code scanning / Markdownlint (reported by Codacy)
Expected: 80; Actual: 98
This was referenced Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that
-DENABLE_MODERNis required to be OFF, because enabling that pulls in that proton include from #68