mok: relax the maximum variable size check #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some UEFI environment such as u-boot doesn't implement QueryVariableInfo(), so we couldn't rely on the function to estimate the available space for RT variables. All we can do is to call SetVariable() directly and check the return value of SetVariable(). Signed-off-by: Gary Lin <glin@suse.com>
Collaborator
|
It's worth pointing out that some firmware implementations (Apple 2.40) even lie and tell you they have space but then die/hang when you try to write :D |
Collaborator
Author
|
We had a similar case that the firmware lied about the space, but the firmware kindly returned EFI_OUT_OF_RESOURCES :-p |
Collaborator
|
+1 on merging We got hit by this too https://bugs.launchpad.net/ubuntu/+source/shim/+bug/1934780 and verified this fixes it. Thanks! |
julian-klode
approved these changes
Jul 6, 2021
9 tasks
joeyli
added a commit
to joeyli/shim
that referenced
this pull request
Oct 17, 2025
…MokListRT The new building option DISABLE_APPEND_V_DBX_TO_MOKX avoids appending the vendor_dbx to MokListRT. Instead, the vendor_dbx will be exposed through the mok config table space. As the vendor-dbx grows, it caused some problems when writing such a large variable. Some firmwares lie the avaiable space [1], and some even crash [2] for no good reason after the writing of MokListXRT. If your shim and kernel don't rely on MokListXRT to block anything, you can use this building option to expose vendor_dbx through the mok config table instead of appending it to MokListRT. Link: https://bugzilla.suse.com/show_bug.cgi?id=1185261 [1] Link: rhboot#369 (comment) [2] Signed-off-by: Chun-Yi Lee <jlee@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some UEFI environment such as u-boot doesn't implement
QueryVariableInfo(), so we couldn't rely on the function to estimate the
available space for RT variables. All we can do is to call SetVariable()
directly and check the return value of SetVariable().
Signed-off-by: Gary Lin glin@suse.com