fix ignore BufEnter and BufLeave events when create popup window#83
Open
Alex-duzhichao wants to merge 1 commit intorhysd:masterfrom
Open
fix ignore BufEnter and BufLeave events when create popup window#83Alex-duzhichao wants to merge 1 commit intorhysd:masterfrom
Alex-duzhichao wants to merge 1 commit intorhysd:masterfrom
Conversation
After popup window has been created, git-messenager uses `noautocmd wincmd p` to jump back to the current buffer, which ignores BufEnter and BufLeave events. Some other plugins depends on event BufEnter/BufLeave to take effect normally. So git-messenager should use `wincmd p` to preserve events. See issue rhysd#65 for details.
Owner
|
Did you confirm that this causes no issue? I concern that the following auto commands are unexpectedly triggered by this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After popup window has been created, git-messenager uses
noautocmd wincmd pto jump back to the current buffer, whichignores BufEnter and BufLeave events. Some other plugins depends
on event BufEnter/BufLeave to take effect normally. So git-messenager
should use
wincmd pto preserve events.See issue #65 for details.