Allow configuring a name for the archived binary #43
Conversation
|
(Noticed the build failed but I'm at the end of my day, will take a closer look tomorrow 🙇🏼) |
This will default to the existing behavior: using the name of the currently running executable. Fixes rhysd#42
|
|
||
| func setupTestBinary() { | ||
| if err := exec.Command("go", "build", "./testdata/github-release-test/").Run(); err != nil { | ||
| func setupTestBinary(name ...string) { |
There was a problem hiding this comment.
The changes in here and teardownTestBinary feel a bit hacky. An alternative I considered was using a new repo (i.e rhysd-test/test-release-different-name) which would have contained an archive with a differently named binary, and thus we could leave these two methods here as-is.
Do you have a preference @rhysd ?
|
FWIW, this is merged in our fork (rainforestapp/go-github-selfupdate) and used by our CLI (see PR implementing it here: https://github.com/rainforestapp/rainforest-cli/pull/413/files), so I can confirm this works in the real world 😅 |
|
Yes. This repo seems to be no longer maintained. I will move to use yours @magni- |
2 participants
This will default to the existing behavior: using the name of the currently running executable.
I don't write much Go, so hopefully I didn't do things too terribly 😬
Fixes #42