fix(se): add Paskdagen and Pingstdagen to Holidays slice#153
Merged
rickar merged 1 commit intorickar:masterfrom Jan 24, 2026
Merged
Conversation
The Swedish holidays Paskdagen (Easter Sunday) and Pingstdagen
(Whit Sunday/Pentecost) were defined as variables but were not
included in the Holidays slice, making them unavailable when
using the convenience slice.
Both holidays are official Swedish public holidays ("röda dagar"):
- Paskdagen: Easter Sunday
- Pingstdagen: 49 days after Easter (Pentecost Sunday)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Paskdagen(Easter Sunday) to theHolidaysslicePingstdagen(Whit Sunday/Pentecost) to theHolidayssliceProblem
The Swedish holidays
PaskdagenandPingstdagenare defined as variables in the package but were not included in the convenienceHolidaysslice. This means users who iterate overse.Holidaysto add all Swedish holidays to their calendar would be missing these two official public holidays.Both are official Swedish public holidays ("röda dagar"):
Testing
se_holidays_test.goTest plan
go test ./v2/se/...passesgo test ./v2/...passes (all country packages)🤖 Generated with Claude Code