Merge for RMDoor#8
Open
richorr wants to merge 14 commits intorickparrish:masterfrom
Open
Conversation
Owner
|
Thanks for the updates. A few requests before merging:
|
All write-path Open* functions now acquire an exclusive advisory lock (fpfcntl F_SetLk/F_WRLCK on Unix; FileMode fmShareExclusive on Windows) after a successful open. If the lock is unavailable the file is closed and retried within the existing timeout loop. Locks release on Close(). LockFile and UnLockFile replaced their Halt stubs with real fpfcntl implementations (F_SetLkW blocking lock / F_UNLCK unlock). Fixes concurrent-write race conditions in multi-user BBS deployments. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
cint is defined by BaseUnix which is Unix-only, but the function signature was unconditional. On Windows the parameter is never used (function returns true immediately; exclusive access is enforced at open time via fmShareExclusive). Use LongWord on Windows to match the THandle type returned by FileRec/TextRec.Handle. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.