Skip to content

Fixing mount/ unmount crash #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kingdcreations merged 1 commit into from
May 17, 2022
Merged

Fixing mount/ unmount crash #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions android/src/main/java/com/reactnativearviewer/ArViewerView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,10 @@ open class ArViewerView @JvmOverloads constructor(
}
}

fun onDrop() {
super.onDetachedFromWindow()
}

/**
* Start the loading of a GLB model URI
*/
Expand Down Expand Up @@ -190,14 +194,14 @@ open class ArViewerView @JvmOverloads constructor(
*/
override fun onArSessionCreated(session: ArSession) {
super.onArSessionCreated(session)
Log.d("ARview session", "started")
val event = Arguments.createMap()
val reactContext = context as ReactContext
reactContext.getJSModule(RCTEventEmitter::class.java).receiveEvent(
id,
"onStarted",
event
)
Log.d("ARview session", "started")
val event = Arguments.createMap()
val reactContext = context as ReactContext
reactContext.getJSModule(RCTEventEmitter::class.java).receiveEvent(
id,
"onStarted",
event
)
}

/**
Expand Down
1 change: 1 addition & 0 deletions android/src/main/java/com/reactnativearviewer/ArViewerViewManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ class ArViewerViewManager : SimpleViewManager<ArViewerView>() {
override fun onDropViewInstance(view: ArViewerView) {
Log.d("ARview onDropViewInstance", "Stopping session");
super.onDropViewInstance(view)
view.onDrop()
val threadPause: Thread = object : Thread() {
override fun run() {
try {
Expand Down