Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions pullrequests/string_to_integer_atoi/step1.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
//lint:file-ignore U1000 Ignore all unused code
package stringtointegeratoi

import "math"

/*
時間:20分
解法自体はすぐに思いついたのですが、色々とバグを取り除くのに時間がかかってしまいました。
*/
func myAtoi_step1(s string) int {
const (
intMax = int(math.MaxInt32)
intMin = int(math.MinInt32)
)
sign := 1
i := 0
num := 0
for i < len(s) && s[i] == ' ' {
i++
}
if i < len(s) && (s[i] == '-' || s[i] == '+') {
if s[i] == '-' {
sign = -1
}
i++
}
for i < len(s) && s[i] == '0' {
i++
}
for i < len(s) && '0' <= rune(s[i]) && rune(s[i]) <= '9' {
num = num*10 + int(rune(s[i])-'0')
if sign == 1 && num > intMax {
return intMax
}
if sign == -1 && -num < intMin {
return intMin
}
i++
}
return num * sign
}
40 changes: 40 additions & 0 deletions pullrequests/string_to_integer_atoi/step2.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
//lint:file-ignore U1000 Ignore all unused code
package stringtointegeratoi

import "math"

/*
Goではrune型はint32、byte型はint8のエイリアスで、明示的にキャストしなくても内部でキャストしてくれるので、そのまま比較できるため、rune型にキャストするのをやめました。
*/
func myAtoi_step2(s string) int {
const (
intMax = int(math.MaxInt32)
intMin = int(math.MinInt32)
)

i := 0
for i < len(s) && s[i] == ' ' {
i++
}

sign := 1
if i < len(s) && (s[i] == '-' || s[i] == '+') {
if s[i] == '-' {
sign = -1
}
i++
}

num := 0
for i < len(s) && '0' <= s[i] && s[i] <= '9' {
num = num*10 + int(s[i]-'0')
if sign == 1 && num > intMax {
return intMax
}
if sign == -1 && -num < intMin {
return intMin
}
i++
}
return sign * num
}
41 changes: 41 additions & 0 deletions pullrequests/string_to_integer_atoi/step3.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
//lint:file-ignore U1000 Ignore all unused code
package stringtointegeratoi

import "math"

/*
32bit環境でもオーバーフローしないようにコードを変えてみました。
*/
func myAtoi(s string) int {
const (
intMax = int(math.MaxInt32)
intMin = int(math.MinInt32)
)

i := 0
for i < len(s) && s[i] == ' ' {
i++
}

sign := 1
if i < len(s) && (s[i] == '-' || s[i] == '+') {
if s[i] == '-' {
sign = -1
}
i++
}

num := 0
for i < len(s) && '0' <= s[i] && s[i] <= '9' {
next := int(s[i] - '0')
if sign != -1 && num > (intMax-next)/10 {
return intMax
}
if sign == -1 && -num < (intMin+next)/10 {
return intMin
}
num = num*10 + next
i++
}
return sign * num
}
41 changes: 41 additions & 0 deletions pullrequests/string_to_integer_atoi/step4.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
//lint:file-ignore U1000 Ignore all unused code
package stringtointegeratoi

import "math"

/*
Step3のオーバーフローしてしまうバグを直しました。
*/
func myAtoi_step4(s string) int {
const (
intMax = int(math.MaxInt32)
intMin = int(math.MinInt32)
)

i := 0
for i < len(s) && s[i] == ' ' {
i++
}

sign := 1
if i < len(s) && (s[i] == '-' || s[i] == '+') {
if s[i] == '-' {
sign = -1
}
i++
}

num := 0
for i < len(s) && '0' <= s[i] && s[i] <= '9' {
digit := int(s[i] - '0')
if sign == 1 && (num > intMax/10 || num == intMax/10 && digit >= intMax%10) {
return intMax
}
if sign == -1 && (-num < intMin/10 || -num == intMin/10 && -digit <= intMin%10) {
return intMin
}
num = num*10 + digit
i++
}
return sign * num
}