Conversation
colorbox
reviewed
Sep 6, 2024
colorbox
reviewed
Sep 6, 2024
oda
reviewed
Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement Queue using Stacksを解きました。レビューをお願い致します。
問題:https://leetcode.com/problems/implement-queue-using-stacks/
言語:Go
既に解いている方々:
colorbox/leetcode#15
構造体の初期化
MyQueue{}と初期化すると、メンバ自体はゼロ値で初期化されるため、今回の場合はthis.pushStack == nil && this.popStack == nilになる。そのためthis.pushStackのようにメンバにアクセスしてもヌルポにはならない。またnilスライスに対してappend操作を行うと、新しいスライスが作成されて要素が追加されるため、これも問題ない。MyQueue{}はMyQueue{pushStack: []int{}, popStack: []int{}}やMyQueue{[]int{}, []int{}}とも書くことができ、どれも同じである。new(MyQueue)と初期化すると、MyQueue{}と同様にメンバはゼロ値で初期化されるが、MyQueue{}はMyQueue型の値が返されるのに対して、MyQueue型のポインタが返される。q := MyQueue{}とvar q MyQueueは実質的な違いはない。どちらもメンバがゼロ値で初期化されたMyQueue型の値がqに格納される。