Modules modernization #412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
October 29, 2020 13:02
… ByteString (these are globally defined)
binary module uses defineClass to modify the global scope, so we can't (re)declare ie. const Binary
disentangled Frame and Profiler constructors: moved Frame constructor out of Profiler constructor, and pass the stack it needs as argument
added 12 commits
November 2, 2020 14:08
removed partition() method - this method was obviously broken and not covered by tests, so i assume it's obsolete
…eUpload() - unfolding multiline headers couldn't have worked
(now deprecated) String.prototype.toByteString() method
botic
approved these changes
Nov 3, 2020
Member
botic
left a comment
botic
left a comment
There was a problem hiding this comment.
Good someone started this 👍 I just flew over all sections, nothing in which would prevent a merge.
added 10 commits
November 3, 2020 13:19
ArgumentsError (jsdoc rendered the constructor property)
…const variables, otherwise RingoShell class is unable to invoke them.
removed hasOwnProperty() check since Object.keys() returns only own enumerable property names
also fixes toByteString to return a ByteString, not a ByteArray
Member
|
@grob ready to merge, or still outstanding work from your side? |
Member
Author
|
No, i'm fine with that (#415 is pending too). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite a code bomb, but no (intentional) functional changes: replaced
vardeclarations in all standard modules withconst/let, modernized code where possible. All tests pass, some tests were added.Note that due to #411 i had to change some module imports to eg.
const binary = require("binary");and usebinary.ByteArraythroughout the module.