refactor: paystring remove redux and payid-lib#649
Merged
Conversation
Switch from redux to react-query and payid-lib to @paystring/utils. This eliminates ~200 lines.
pdp2121
approved these changes
Mar 31, 2023
JST5000
reviewed
Apr 4, 2023
|
|
||
| it('renders static parts', () => { | ||
| const wrapper = creatWrapper() | ||
| const wrapper = createWrapper() |
Contributor
There was a problem hiding this comment.
nice catch :) (Took me a couple reads to see the difference)
JST5000
reviewed
Apr 4, 2023
src/rippled/payString.ts
Outdated
| addressDetailsType: string | ||
| addressDetails: { | ||
| address: string | ||
| tag: string // optional |
Contributor
There was a problem hiding this comment.
Should this be written as tag?: string instead of this comment? or is the implication that it can be empty?
Collaborator
Author
There was a problem hiding this comment.
Just confirmed the output from the server and it will be undefined.
JST5000
approved these changes
Apr 4, 2023
Contributor
JST5000
left a comment
JST5000
left a comment
There was a problem hiding this comment.
LGTM after a small question
1 task
achowdhry-ripple
added a commit
that referenced
this pull request
Apr 8, 2025
## High Level Overview of Change This PR removes the last of redux from the codebase. The only two pieces left were Account and Token. It also removes all mentions of gravatars. This also reduces the size of the build by about 35kb. There were some build issues that required regenerating the package-lock, which is almost all of the diff. ### Context of Change * #649 * #640 * #635 * #634 * #1100 ### Type of Change - [x] Refactor (non-breaking change that only restructures code) ### TypeScript/Hooks Update N/A ## Test Plan Tests were fixed to handle the refactor. --------- Co-authored-by: Ashray Chowdhry <achowdhry@ripple.com>
heap-coder
added a commit
to heap-coder/explorer
that referenced
this pull request
Sep 27, 2025
## High Level Overview of Change This PR removes the last of redux from the codebase. The only two pieces left were Account and Token. It also removes all mentions of gravatars. This also reduces the size of the build by about 35kb. There were some build issues that required regenerating the package-lock, which is almost all of the diff. ### Context of Change * ripple/explorer#649 * ripple/explorer#640 * ripple/explorer#635 * ripple/explorer#634 * ripple/explorer#1100 ### Type of Change - [x] Refactor (non-breaking change that only restructures code) ### TypeScript/Hooks Update N/A ## Test Plan Tests were fixed to handle the refactor. --------- Co-authored-by: Ashray Chowdhry <achowdhry@ripple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Switch from redux to react-query and payid-lib to @paystring/utils.
This eliminates ~200 lines.
This is a recreation of #639.
Type of Change
TypeScript/Hooks Update