ggml-cpu: add 128-bit RVV implementation for Quantization Vector Dot#9
Merged
taimur-10x merged 3 commits intomasterfrom Mar 18, 2026
Merged
ggml-cpu: add 128-bit RVV implementation for Quantization Vector Dot#9taimur-10x merged 3 commits intomasterfrom
taimur-10x merged 3 commits intomasterfrom
Conversation
taimur-10x
force-pushed
the
10x/riscv-quant-vec-dot-128b
branch
from
51b400b to
8bd5cbe
Compare
rehan-10xengineer
force-pushed
the
10x/riscv-quant-vec-dot-128b
branch
from
21b6845 to
a22b149
Compare
taimur-10x
force-pushed
the
10x/riscv-quant-vec-dot-128b
branch
2 times, most recently
from
f8f9384 to
2785c94
Compare
rehan-10xengineer
force-pushed
the
10x/riscv-quant
branch
3 times, most recently
from
9ca80fc to
68e3cee
Compare
rehan-10xengineer
force-pushed
the
10x/riscv-quant-vec-dot-128b
branch
from
2785c94 to
f83ddf7
Compare
github-actions
Bot
added
documentation
rehan-10xengineer
force-pushed
the
10x/riscv-quant-vec-dot-128b
branch
from
f83ddf7 to
c7c6abc
Compare
Collaborator
|
opened pr upstreamhere |
taimur-10x
force-pushed
the
10x/riscv-quant-vec-dot-128b
branch
from
c7c6abc to
d618925
Compare
taimur-10x
removed
documentation
Co-authored-by: Rehan Qasim <rehan.qasim@10xengineers.ai>
taimur-10x
force-pushed
the
10x/riscv-quant-vec-dot-128b
branch
from
d618925 to
cf95828
Compare
taimur-10x
force-pushed
the
10x/riscv-quant-vec-dot-128b
branch
from
cf95828 to
05a5425
Compare
rehan-10xengineer
pushed a commit
that referenced
this pull request
Apr 14, 2026
) * ggml: backend-agnostic tensor parallelism * support for GPT-OSS, Qwen 3 MoE * partial Vulkan fix * add support for 4/8 GPUs * unconditional peer access * re-use buffers + ggml contexts * fix output pattern * NCCL support * GGML: HIP: add RCCL support * Remove shfl and AllReduce from backend interface * move allocation workaround out of ggml-alloc.c * 2d tensor set/get support * Fix the seg fault without NCCL * Apply suggestion from JohannesGaessler * support for tensor dims % n_devs != 0 * fix view_offs scaling * arbitrary num. of GPUs/tensor split * fix compilation * better granularity estimate * Support device-specific host buffer types if all underlying backends expose the same type. This allows using pinned memory instead of pageable memory for CUDA. Fix compilation errors. * partial Qwen 3 Next support * Fix qwen3 30b (#8) * Fix crash with Qwen-30B-A3B Q4_0 Qwen-30B-A3B Q4_0 has an intermediate dimension of 768. Using a granularity of 256 forces an uneven split between GPUs, which is not supported by the current implementation. * Decide block size based on tensor quantization type * Fix crashes due to KV cache serialization (#9) KV cache serialization requires non-zero offsets on the tensor. Add support in the meta backend to set/get a tensor with a non-zero offset. * metal : fix build (#7) * static memory allocations, fix usage count * fix tensor granularity * more even memory distribution * use BF16 for allreduce * rebase fixup * better error message for unsupported architectures * Fix device mismatch during scatter of allReduce. (#11) There is a mismatch between the dst buffer device and the backend device, causing the use of sync copies * Enable the previous allreduce implementation. It is better in both perf and stability (#12) * delay AllReduce for Moe for less I/O * build : clean-up compile warnings * backend : move most of the meta backend API to ggml-backend-impl.h * cont : hide unused public API in the implementation * llama : use llama_device + remove ggml_backend_dev_is_meta() * ggml-backend : remove unused alloc include * minor : remove regex include * ggml : introduce ggml-ext.h for staging new APIs * rebase fixup * fix tests * llama : more robust logic for determining Meta devices (ggml-org#16) * llama : more robust logic for determining Meta devices * cont : fix devs size check Co-authored-by: Johannes Gäßler <johannesg@5d6.de> * cont : fix log type Co-authored-by: Johannes Gäßler <johannesg@5d6.de> --------- Co-authored-by: Johannes Gäßler <johannesg@5d6.de> * disable roundtrip for meta backend * fix arch selection * Qwen 3.5 support * fix Gemma 4 MoE * fix OpenVino, SYCL * fix test-llama-archs for CPU-only builds * Fix Qwen 3.5 MoE * disable meta backend tests for WebGPU * tests : filter CPU-based devices from the Meta backend tests (ggml-org#17) * meta : formatting, naming, indentation (ggml-org#18) * formatting : llama-model.cpp * formatting : ggml-ext.h * formatting : ggml-backend-meta.cpp * meta : add TODO * add documentation * better error messages * fix GPT-OSS --------- Co-authored-by: Carl Philipp Klemm <carl@uvos.xyz> Co-authored-by: Gaurav Garg <gaugarg@nvidia.com> Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds RVV 128-bit implementations for quantized vector dot kernels.
Key Changes
Testing
Kernels were functionally tested through
test-quantize-fnsfor128-biton QEMU.Future Work
Subsequent PRs plan to extend existing RVV kernels for quantization types to higher VLENs (512-bit and 1024-bit).