-
Notifications
You must be signed in to change notification settings - Fork 8
Hi, please consider these changes. #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| function Ensure-SQLTools{ | ||
| param( | ||
| [int]$majorPSVersion | ||
| ) | ||
|
|
||
| if($majorPSVersion -gt 4) | ||
| { | ||
| $confirmSqlServer = Get-Module SqlServer -ListAvailable | ||
| if(!$confirmSqlServer) | ||
| { | ||
| Try | ||
| { | ||
| Install-Module -Name SqlServer -AllowClobber | ||
| Write-Host "Loaded SqlServer module" | ||
| } | ||
| Catch | ||
| { | ||
| Write-Host "SqlServer not available via PowerShell Gallery, check connection settings" | ||
| } | ||
| } | ||
| else | ||
| { | ||
| Write-Host "SqlServer module is loaded" | ||
| } | ||
| } | ||
| else | ||
| { | ||
| $confirmSQLPS = Get-Module SQLPS -ListAvailable | ||
| if(!$confirmSQLPS) | ||
| { | ||
| Try | ||
| { | ||
| Import-Module "SQLPS" -DisableNameChecking | ||
| Write-Host "Loaded SQLPS module" | ||
| } | ||
| Catch | ||
| { | ||
| Write-Host "SQLPS not available to import; installation needed" | ||
| } | ||
| } | ||
| else | ||
| { | ||
| Write-Host "SQLPS module is loaded" | ||
| } | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -76,6 +76,15 @@ | |
| "required": false, | ||
| "helpMarkDown": "If you want Cobertura reports to be generated for the test execution, enable this.", | ||
| "groupName": "codeCoverage" | ||
| }, | ||
| { | ||
| "name": "enableAzure", | ||
| "type": "boolean", | ||
| "label": "Enable Azure SQL", | ||
| "defaultValue": "false", | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As we've been working on a cloud world, do you think that it makes sense to leave it true by default? |
||
| "required": false, | ||
| "helpMarkDown": "If you want to get the result from a Azure SQL Server, enable this.", | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was also thinking about requesting this info from the user as a Dropdown list. What do you think? This way, we could ask for something like: "SQL Server technology/service type":
And then we'd handle this on the scripts. |
||
| "groupName": "codeCoverage" | ||
| }, | ||
| { | ||
| "name": "coberturaFileName", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There may have a comma missing here, after $queryTimeout.
I think it breaks the code execution. But in case we're not sure, it would be good to keep the standard.