PeriodicJob ByArgs since 0.27.0 upgrade

[bertpersyn-nxh]

Hi!

After upgrading to 0.27.0, our tests started to fail with the following message:

expected struct, got string

Command:

type OurCommand struct {
	basecommand.CommandMetaData
	SomeBool bool
}
type CommandMetaData struct {
	UserContextName requestmetadata.UserContext `json:"userContextName"`
	OwnerOrgID      uuid.UUID                   `json:"ownerOrgID"` // references our own uuid package
	Flags           map[string]bool             `json:"flags,omitempty"`
}
---
package uuid

import (
...
	"github.com/google/uuid"
)

type UUID struct {
	uuid.UUID
}

InsertOpts

&river.InsertOpts{
			UniqueOpts: river.UniqueOpts{
				ByPeriod: 8 * 60 * time.Minute,
				ByArgs:   true,                 
			},
			Tags: []string{"periodic"},
		},

A debug session let me to this: https://github.com/riverqueue/river/pull/1076/files

internal/dbunique/unique_fields.go -> uniqueSubFields

err := getSortedUniqueFields(field.Type, path).

It was for the field ownerOrgID.

Did not debug further or try to fix it.

Any ideas?

[brandur]

Can you show the definition of your custom uuid.UUID type?

NM, I see it in your example now.

[brandur]

Have a fix in at #1088.

[bertpersyn-nxh]

Thx for the fast reply. Now I see this 👁️

This probably because our Command contains a self ref:

type Command struct {
	basecommand.CommandMetaData
	Message               Msg `json:"msg"`
	ID                  uuid.UUID    
}

type Msg struct {
	Obj   *Obj `json:"-"`
}

type Obj struct {
	PreviousObj   *Obj `json:"-"`
}

I suppose it is partly our fault for not creating clean commands.

Could you guard against this too?

runtime: goroutine stack exceeds 1000000000-byte limit
runtime: sp=0x1402c000360 stack=[0x1402c000000, 0x1404c000000]
fatal error: stack overflow

runtime stack:
runtime.throw({0x105f9d9ba?, 0x10412af1c?})
	/Users/bert/go/go1.24.10/src/runtime/panic.go:1101 +0x38 fp=0x1725eedc0 sp=0x1725eed90 pc=0x10418d698
runtime.newstack()
	/Users/bert/go/go1.24.10/src/runtime/stack.go:1107 +0x45c fp=0x1725eef00 sp=0x1725eedc0 pc=0x10417234c
runtime.morestack()
	/Users/bert/go/go1.24.10/src/runtime/asm_arm64.s:342 +0x70 fp=0x1725eef00 sp=0x1725eef00 pc=0x104193df0

goroutine 3923 gp=0x14002f01180 m=14 mp=0x14000c00008 [running]:
reflect.(*structType).Field(0x106ee0fa0?, 0x0?)
	/Users/bert/go/go1.24.10/src/reflect/type.go:1102 +0x1b8 fp=0x1402c000360 sp=0x1402c000360 pc=0x104207068
reflect.(*rtype).Field(0x0?, 0x0?)
	/Users/bert/go/go1.24.10/src/reflect/type.go:745 +0x50 fp=0x1402c000470 sp=0x1402c000360 pc=0x10421ca40
github.com/riverqueue/river/internal/dbunique.getSortedUniqueFields({0x106f91bd0?, 0x106ee0fa0?}, {0x14052594000, 0xea0d7, 0x10ee00})
	/Users/bert/go/pkg/mod/github.com/riverqueue/river@v0.27.1-0.20251121075549-ebc0ce1643d1/internal/dbunique/unique_fields.go:60 +0x190 fp=0x1402c0006a0 sp=0x1402c000470 pc=0x10478d840
github.com/riverqueue/river/internal/dbunique.getSortedUniqueFields({0x106f91bd0?, 0x106d0e4e0?}, {0x14052594000, 0xea0d6, 0x10ee00})
	/Users/bert/go/pkg/mod/github.com/riverqueue/river@v0.27.1-0.20251121075549-ebc0ce1643d1/internal/dbunique/unique_fields.go:100 +0x4c8 fp=0x1402c0008d0 sp=0x1402c0006a0 pc=0x10478db78

[brandur]

Okay, I think I got that one too over in #1090.

[bertpersyn-nxh]

Tested with both changes and I can confirm it works.

I suppose I'll wait for the 0.27.1 release, verify and close this one.

Thx

[brandur]

Excellent. Thanks for checking that. Both patches are pretty small so hopefully we can get a release cut tomorrow.