Skip to content

Fix EventKindJobSnoozed detection in rivertest.Worker #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandur merged 1 commit into from
Oct 14, 2025
Merged

Fix EventKindJobSnoozed detection in rivertest.Worker #1057

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 17 additions & 13 deletions rivertest/worker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,20 +243,24 @@ func completerResultToWorkResult(tb testing.TB, completerResult jobcompleter.Com
tb.Helper()

var kind river.EventKind
switch completerResult.Job.State {
case rivertype.JobStateCancelled:
kind = river.EventKindJobCancelled
case rivertype.JobStateCompleted:
kind = river.EventKindJobCompleted
case rivertype.JobStateScheduled:
if completerResult.Snoozed {
kind = river.EventKindJobSnoozed
case rivertype.JobStateAvailable, rivertype.JobStateDiscarded, rivertype.JobStateRetryable, rivertype.JobStateRunning:
kind = river.EventKindJobFailed
case rivertype.JobStatePending:
panic("test worker internal error: completion subscriber unexpectedly received job in pending state, river bug")
default:
// linter exhaustive rule prevents this from being reached
panic("test worker internal error: unreachable state to distribute, river bug")
} else {
switch completerResult.Job.State {
case rivertype.JobStateCancelled:
kind = river.EventKindJobCancelled
case rivertype.JobStateCompleted:
kind = river.EventKindJobCompleted
case rivertype.JobStateScheduled:
kind = river.EventKindJobSnoozed
case rivertype.JobStateAvailable, rivertype.JobStateDiscarded, rivertype.JobStateRetryable, rivertype.JobStateRunning:
kind = river.EventKindJobFailed
case rivertype.JobStatePending:
panic("test worker internal error: completion subscriber unexpectedly received job in pending state, river bug")
default:
// linter exhaustive rule prevents this from being reached
panic("test worker internal error: unreachable state to distribute, river bug")
}
}

return &WorkResult{
Expand Down
Loading