fix ScheduledAt functionality with InsertManyTx#121
Merged
Conversation
I stumbled upon this fairly egregious bug in my own test app. It turns out when you insert with `InsertManyTx`, `ScheduledAt` is not respected and we never even added it to the underlying query. Instead, the job is enqueued immediately as available and worked right away. This fixes the bug by respecting `ScheduledAt` the same on bulk inserts as for individual inserts. I added a test to verify the broken behavior and then fixed it.
bgentry
force-pushed
the
bg-fix-insertmanytx-scheduled-jobs
branch
from
ed630ef to
3a3093d
Compare
brandur
added a commit
that referenced
this pull request
Dec 22, 2023
Seems like a good idea to cut a version that includes #121. Here, add a banner for 0.0.15 to the changelog so we can cut a release.
brandur
added a commit
that referenced
this pull request
Dec 22, 2023
Seems like a good idea to cut a version that includes #121. Here, add a banner for 0.0.15 to the changelog so we can cut a release.
brandur
added a commit
that referenced
this pull request
Dec 22, 2023
Seems like a good idea to cut a version that includes #121. Here, add a banner for 0.0.15 to the changelog so we can cut a release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I stumbled upon this fairly egregious bug in my own test app. It turns out when you insert with
InsertManyTx,ScheduledAtis not respected and we never even added it to the underlying query. Instead, the job is enqueued immediately as available and worked right away.This fixes the bug by respecting
ScheduledAtthe same on bulk inserts as for individual inserts. I added a test to verify the broken behavior and then fixed it.I also pulled in a sqlc upgrade commit from #117 to avoid needing to work around having a newer version locally.