Upgrade golangci-lint GitHub Action go v5 and linter to 1.56#223
Merged
Upgrade golangci-lint GitHub Action go v5 and linter to 1.56#223
v5 and linter to 1.56#223Conversation
brandur
force-pushed
the
brandur-golangci-lint-v5
branch
2 times, most recently
from
363f08b to
2ea003f
Compare
Contributor
Author
|
@bgentry Super small one, and remember to upgrade your local version. |
A small one to upgrade: * golangci-lint GitHub Action from `v4` to `v5` * golangci-lint from 1.55 to 1.56 A small change, but I upgraded locally at some point, and it's causing a build issue in #212. The `tparallel` lint previously had a bug where it'd want you to put a `t.Parallel()` on test cases that use `t.Setenv()`, even though use of `t.Parallel()` with `t.Setenv()` is disallowed by Go's test framework, so you'd have to mark those test cases with `nolint`. That bug's been fixed now, and now the linter detects that the `nolint` is no longer necessary, and automatically strips it out with my upgraded golangci-lint version, causing a failure when I push to CI. The `v5` GitHub Action is also somewhat nice because it stops using a deprecated NodeJS version, so produces fewer warnings in the log.
brandur
force-pushed
the
brandur-golangci-lint-v5
branch
from
2ea003f to
f86e22b
Compare
bgentry
approved these changes
Feb 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small one to upgrade:
v4tov5A small change, but I upgraded locally at some point, and it's causing a
build issue in #212. The
tparallellint previously had a bug whereit'd want you to put a
t.Parallel()on test cases that uset.Setenv(),even though use of
t.Parallel()witht.Setenv()is disallowed by Go'stest framework, so you'd have to mark those test cases with
nolint.That bug's been fixed now, and now the linter detects that the
nolintis no longer necessary, and automatically strips it out with my upgraded
golangci-lint version, causing a failure when I push to CI.
The
v5GitHub Action is also somewhat nice because it stops using adeprecated NodeJS version, so produces fewer warnings in the log.