better client logs for flaky insert and work test, shorter test connect timeout#224
Merged
better client logs for flaky insert and work test, shorter test connect timeout#224
Conversation
Contributor
Author
brandur
approved these changes
Feb 25, 2024
The intention here is to avoid attempts that are likely to hang forever, and instead give up while there's still enough time for the test to have a chance of succeeding.
bgentry
force-pushed
the
bg-rework-insert-test
branch
from
e26518a to
8158e23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contains a few small fixes and logging improvements encountered while debugging flaky tests from #213. The main one that actually fixes one of the flaky scenarios is included in the final commit: shortening
ConnectTimeoutfrom 10s to 2s in tests. By failing faster than our typical test timeout, the occasional flaky conn attempt that hangs will no longer make the test immediately fail. In my testing this completely eliminated this one flaky test cause (of several).