fix memory leak on job execution from baseservice#240
Merged
Conversation
bgentry
force-pushed
the
bg-fix-baseservice-rand-mem-leak
branch
from
9805316 to
80432fb
Compare
Closed
brandur
approved these changes
Feb 29, 2024
Contributor
brandur
left a comment
brandur
left a comment
There was a problem hiding this comment.
Awesome. Thanks for the fix!
bgentry
force-pushed
the
bg-fix-baseservice-rand-mem-leak
branch
from
80432fb to
95ecd58
Compare
The `BaseService` type was originally only used for long-running internal services. At some point, we refactored the job execution code to also make use of this type. That exposed a memory leak: every time a new `BaseService` is `Init`'d, a new random source is allocated. That meant for every single job. This is of course totally unnecessary, and to avoid it we can move the rand source to the `Archetype`, which is only allocated once per client. Partially fixes #239.
bgentry
force-pushed
the
bg-fix-baseservice-rand-mem-leak
branch
from
95ecd58 to
fb8ff63
Compare
brandur
added a commit
that referenced
this pull request
Feb 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
BaseServicetype was originally only used for long-running internal services. At some point, we refactored the job execution code to also make use of this type. That exposed a memory leak: every time a newBaseServiceisInit'd, a new random source is allocated. That meant for every single job.This is of course totally unnecessary, and to avoid it we can move the rand source to the
Archetype, which is only allocated once per client.Partially fixes #239.