Tweaks to benchmark client configuration#259
Merged
Conversation
Some tweaks to the benchmark client in #254 which were meant to be included there, but which I apparently forgot to push to GitHub before pushing the "merge" button. See comment [1]. [1] #254 (comment)
bgentry
approved these changes
Mar 10, 2024
Contributor
Author
|
@bgentry Hah sorry for skipping approval. Thanks! |
brandur
added a commit
that referenced
this pull request
Mar 10, 2024
Follows up #259 that added some client configuration tweaks for benchmarks along with comments describing their selection. This is my fault for merging without waiting for review, but there was a minor grammatical mistake and omitted word, which we fix up here.
bgentry
pushed a commit
that referenced
this pull request
Mar 11, 2024
Follows up #259 that added some client configuration tweaks for benchmarks along with comments describing their selection. This is my fault for merging without waiting for review, but there was a minor grammatical mistake and omitted word, which we fix up here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tweaks to the benchmark client in #254 which were meant to be
included there, but which I apparently forgot to push to GitHub before
pushing the "merge" button. See comment [1].
[1] #254 (comment)