Merged
Conversation
Here, fix an intermittent stress test in the notifier package. This is one that I added last minute in #258 in response to code review, so I missed the intermittency because it didn't fail on any of the last pushes that I made, but I noticed it failing today [1]. Luckily, it's quite a simple where we just have to make sure that the test waits for one of the test goroutines to return before quitting. Ran at `-race -count 1000` locally and no longer seeing any intermittency. [1] https://github.com/riverqueue/river/actions/runs/8223455278/job/22486174354
brandur
force-pushed
the
brandur-fix-notifier-intermittent-test
branch
from
62f0b92 to
88f9dd3
Compare
bgentry
approved these changes
Mar 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here, fix an intermittent stress test in the notifier package. This is
one that I added last minute in #258 in response to code review, so I
missed the intermittency because it didn't fail on any of the last
pushes that I made, but I noticed it failing today [1].
Luckily, it's quite a simple where we just have to make sure that the
test waits for one of the test goroutines to return before quitting. Ran
at
-race -count 1000locally and no longer seeing any intermittency.[1] https://github.com/riverqueue/river/actions/runs/8223455278/job/22486174354