Skip to content

effectively disable reindexer #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bgentry merged 1 commit into from
Nov 18, 2023
Merged

effectively disable reindexer #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1310,6 +1310,7 @@ func Test_Client_Maintenance(t *testing.T) {

t.Run("Reindexer", func(t *testing.T) {
t.Parallel()
t.Skip("Reindexer is disabled for further development")

config := newTestConfig(t, nil)
config.ReindexerSchedule = cron.Every(time.Second)
Expand Down
5 changes: 1 addition & 4 deletions internal/maintenance/reindexer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const (
DefaultTimeout = 15 * time.Second
)

var defaultIndexNames = []string{"river_job_metadata_index", "river_job_args_index"} //nolint:gochecknoglobals
var defaultIndexNames = []string{} //nolint:gochecknoglobals

// Test-only properties.
type ReindexerTestSignals struct {
Expand All @@ -43,9 +43,6 @@ type ReindexerConfig struct {
}

func (c *ReindexerConfig) mustValidate() *ReindexerConfig {
if len(c.IndexNames) < 1 {
panic("ReindexerConfig.IndexNames must have at least one entry")
}
if c.ScheduleFunc == nil {
panic("ReindexerConfig.ScheduleFunc must be set")
}
Expand Down